emybart415 / Deduper-ebart

0 stars 0 forks source link

Pseudo review #5

Open titusadt opened 11 months ago

titusadt commented 11 months ago

Hi Emily! Your pseudocode looks good and your function definitions were very clear. I think for you strandedness function, you could make it return a bool depending on if the read is mapped or unmapped and pass whatever is returned into you soft_clipping function. I really like the idea to use sets for the umis!

For the output files, I believe we are supposed to write the first duplicate we see into the file. So maybe as youre comparing positions, if the current read matches to the previous read, write the previous read to the output file.