search

enanomapper / ontologies

The eNanoMapper ontology
https://jbiomedsem.biomedcentral.com/articles/10.1186/s13326-015-0005-5
Other
16 stars 15 forks source link

Several terms needed for ACEnano KI dev are missing from ENM ontology #170

Open UanaF opened 5 years ago

UanaF commented 5 years ago

For ACEnano Knowledge infrastructure we need the following terms which are not present in ENM ontology but they are present in the ontologies from which ENM ontology is composed. Could we add/link them? I am writing here also the link of the terms from the other ontologies, it might be useful.

I have more terms which need annotation but first maybe it is better to see how we can do with these ones. Would be okay if I start to add them based on the adding terms enm tutorial?https://github.com/enanomapper/tutorials/tree/master/Added%20ontology%20terms. Please let me know/keep me updated on the process.

egonw commented 5 years ago

Yes, most certainly okay and indeed very much appreciated to follow the tutorial and add some terms! I recommend making one pull request for each term, and start with one, so that I can give feedback.

egonw commented 5 years ago

@UanaF, let me know if I can assist.

UanaF commented 5 years ago

Hi Egon,

Thank you for offering the help and sorry for my late reply! The tutorial is a v useful resource and I think I can manage; I will start these days to add the terms and notify you for a feedback. I had other urgent tasks lately but will soon finish them and start with ENM ontology terms.

/Oana

Trimis de pe iPhone‑ul meu

Pe 14 iul. 2019, la 12:11, Egon Willighagen notifications@github.com a scris:

@UanaF, let me know if I can assist.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

UanaF commented 5 years ago

Hi Egon,

I tried to add "raw data" (http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C142663) as a child of "data item" (http://purl.obolibrary.org/obo/IAO_0000027). I added in the "ncit.iris" the following: "+(http://purl.obolibrary.org/obo/IAO_0000027):http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C142663 raw data". If I use bioportal to see if the term was added to ENM classes; "raw data" is not there. The same with "suspension" (http://purl.bioontology.org/ontology/npo#NPO_532) in npo.iris. Do the terms need approve from you to be seen in ENM or I am doing something wrong?

egonw commented 5 years ago

You added them to the development version of the ontology. You need to load that version to do such a check. BioPortal only had released versions.

egonw commented 5 years ago

But raw data is also not in the development version. In fact, it is not in the NCIT OWL we start with.

egonw commented 5 years ago

We were using a rather old version of NCIT: https://github.com/enanomapper/ontologies/commit/4c68e083750d47a731e3d43a9c0b08eb2baca0c7

egonw commented 5 years ago

suspension from NPO is actually correctly included.

egonw commented 5 years ago

@UanaF, for Compound use http://purl.obolibrary.org/obo/CHEBI_23367 which is already in ENM.

egonw commented 5 years ago

For pH use http://purl.bioontology.org/ontology/npo#NPO_1814 instead. See also https://github.com/enanomapper/ontologies/commit/75c1b35a3774b54513341692d1e592bce3bff501

egonw commented 5 years ago

Finally (for now), can you explain why you need Temperature for? There are various related terms, which may be the one to use.

UanaF commented 5 years ago

We need temperature for the Measurement protocol > Instrument Parameters; when u set the instrument; which should be an alternative to it?

Oana C. Florean,

Research Scientist,

Edelweiss Connect GmbH

On Fri, Aug 30, 2019 at 1:54 PM Egon Willighagen notifications@github.com wrote:

Finally (for now), can you explain why you need Temperature for? There are various related terms, which may be the one to use.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/enanomapper/ontologies/issues/170?email_source=notifications&email_token=AGBVIUUPBYWVIWIUOOAE2TDQHD357A5CNFSM4H44G6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RKGHQ#issuecomment-526557982, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBVIUQ6K65LATKVHZ4U3Z3QHD357ANCNFSM4H44G6ZQ .

egonw commented 5 years ago

@UanaF, I would suggest http://purl.bioontology.org/ontology/npo#NPO_1806.

UanaF commented 5 years ago

Ah, good, thanks!

Oana C. Florean,

Research Scientist,

Edelweiss Connect GmbH

On Fri, Aug 30, 2019 at 3:37 PM Egon Willighagen notifications@github.com wrote:

@UanaF https://github.com/UanaF, I would suggest http://purl.bioontology.org/ontology/npo#NPO_1806 http://bioportal.bioontology.org/ontologies/ENM/?p=classes&conceptid=http%3A%2F%2Fpurl.bioontology.org%2Fontology%2Fnpo%23NPO_1806&jump_to_nav=true .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/enanomapper/ontologies/issues/170?email_source=notifications&email_token=AGBVIUSZSDT777P3RSIWNQTQHEIABA5CNFSM4H44G6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RQ3MI#issuecomment-526585265, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBVIUSMWHADFDMPXVW6PFTQHEIABANCNFSM4H44G6ZQ .

UanaF commented 5 years ago

Can I have a link for this dev version?

Oana C. Florean,

Research Scientist,

Edelweiss Connect GmbH

On Fri, Aug 30, 2019 at 10:46 AM Egon Willighagen notifications@github.com wrote:

You added them to the development version of the ontology. You need to load that version to do such a check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/enanomapper/ontologies/issues/170?email_source=notifications&email_token=AGBVIURJ5QWPMKKTLVTZGILQHDF55A5CNFSM4H44G6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5Q3K7Q#issuecomment-526497150, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBVIUXCAL6AIAZL2YPIZ33QHDF55ANCNFSM4H44G6ZQ .

egonw commented 5 years ago

It's in https://github.com/enanomapper/ontologies/blob/master/README.md

UanaF commented 5 years ago

Continuation of the new terms needed to be added

Chemical Methods Ontology (CHMO):

Ion-selective electrode http://purl.obolibrary.org/obo/CHMO_0002393 Laser induced breakdown detection http://purl.obolibrary.org/obo/CHMO_0000258 Time of flight secondary ion mass spectrometry http://purl.obolibrary.org/obo/CHMO_0000565 Tip Enhanced Raman Scattering (nano-Raman) http://purl.obolibrary.org/obo/CHMO_0000678 Transmission electron microscopy with electron energy loss spectroscopy http://purl.obolibrary.org/obo/CHMO_0000373 Wide-Angle X-ray Scattering http://purl.obolibrary.org/obo/CHMO_0000207

NanoParticle Ontology (NPO):

DLS intrument http://purl.bioontology.org/ontology/npo#NPO_1766 Electrophoretic mobility http://purl.bioontology.org/ontology/npo#NPO_1315 Medium http://purl.bioontology.org/ontology/npo#NPO_1853 Phase http://purl.bioontology.org/ontology/npo#NPO_1610

National Cancer Institute Thesaurus (NCIT)

Amplitude http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C70831 Conductivity http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C134263 Matrix-Assisted Laser Desorption/Ionization http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C48040 Parameters http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C80474 Purity (resistivity) http://ncicb.nci.nih.gov/xml/owl/EVS/Thesaurus.owl#C62352

lwinckers commented 4 years ago

Freeze-drying http://purl.obolibrary.org/obo/NCIT_C28150 --> Already in ENM?

image

https://bioportal.bioontology.org/ontologies/ENM/?p=classes&conceptid=http%3A%2F%2Fpurl.bioontology.org%2Fontology%2Fnpo%23NPO_1957&jump_to_nav=true

lwinckers commented 4 years ago

Electrophoretic mobility http://purl.bioontology.org/ontology/npo#NPO_1315 --> see issue #184