end-4 / dots-hyprland

i hate minimalism so...
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
4.16k stars 279 forks source link

[Feature] Add Support for ZSH #333

Closed michii-h closed 7 months ago

michii-h commented 7 months ago

What would you like to be added? I prefer the zsh over fish shell. But when I change to zsh, it always uses the default colors. So support for the zsh shell would be awesome.

How will it help Makes the dotfiles more usable for people who prefer zsh.

end-4 commented 7 months ago

@clsty handle the installation please?

clsty commented 7 months ago

@clsty handle the installation please?

Sure, but as for .zshrc, I don't think directly overwrite this file is a good idea. We can let user to source this file though.

Will work on this later.


@end-4 I'll move this file under .config/ags but I'm not sure is this a good place.

end-4 commented 7 months ago

why there?

clsty commented 7 months ago

So, if we put the file under $HOME, we are "trashing" the home directory. And if other places, I'm not sure where. Do you have an idea though?

Maybe ~/.zshrc.d? As ~/.zshrc.d/ags_color.zsh?

end-4 commented 7 months ago

trashing? no? zshrc is supposed to be in home? we're going to ask the user whether they want to overwrite or not right?

else we could have it in "Import Manually" folder

clsty commented 7 months ago

I meant we'd better not to overwrite it, but let user to source it, i.e. put something like this in their .zshrc:

source ~/.zshrc.d/ags_colors.zsh
clsty commented 7 months ago

I'll put it in ~/.config/zshrc.d/ for now.

Feel free to talk more about it or make further changes.

clsty commented 7 months ago

Done.

(The color looks weird on my zsh, so personally I'm not sourcing it. Very probably because I'm already using another zsh theme.)

After sourcing (similar to typing >dark as actions) : image

Without sourcing: image

end-4 commented 7 months ago

your prompt looks not very readable because you're using colors wrong (i do that too lol) colors are meant to be on bg color, not on top of each other,

clsty commented 7 months ago

your prompt looks not very readable because you're using colors wrong (i do that too lol) colors are meant to be on bg color, not on top of each other,

I'm not sure, just using a preset of p10k and did not tweak around its colorscheme.

michii-h commented 7 months ago

Thanks a lot, works perfectly :)