end-4 / dots-hyprland

i hate minimalism so...
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
3.71k stars 255 forks source link

Material You schemes support, transparency in AGS, colorscheme UI and more #337

Closed midn8hustlr closed 5 months ago

midn8hustlr commented 5 months ago

Major Changes:

https://github.com/end-4/dots-hyprland/assets/47367711/611d4fc6-d794-4828-9664-fb7a10e7128c

Note:

Suggestions are welcome.

end-4 commented 5 months ago

Very awesomehypr

I am not a fan of creating new material colors by mixing with other colors or changing the opacity

Well, same. I admit that it sucks.

I very welcome this change and will try to review as soon as possible

end-4 commented 5 months ago

It works So far my favourite is "Vibrant"

end-4 commented 5 months ago

@clsty what do you think about this way of installing the python library? I'm not a fan of having the shebang point to a specific location in /opt, but idk if there's a better way

clsty commented 5 months ago

@clsty what do you think about this way of installing the python library? I'm not a fan of having the shebang point to a specific location in /opt, but idk if there's a better way

I'm not very experienced with python lib installaion too, but /opt sure is a proper and common place to install programs to, when not using system package manager. So I think it is OK.


If it is just about shebang, then instead of changing shebang, how about using source /opt/materialyoucolor/bin/activate?


If you still want a better way, then submitting a new AUR package I guess, which I don't have any experience on for now. Reference PKGBUILD of python-material-color-utilities

midn8hustlr commented 5 months ago

If it is just about shebang, then instead of changing shebang, how about using source /opt/materialyoucolor/bin/activate?

I did try to do it in this way first, but after executing the python script you also have to run the 'deactivate' command to exit from virtual environment, otherwise any python script downstream using other python libs from system like gradience-cli will not work. You have add three lines of bash everytime using this script (in AGS modules too inside execAsync), this makes the script less portable imo. Also instead of /opt, we can install the libs in home directory which will not need sudo permissions, but I wasn't able to find a way to point the shebang to ${HOME} or ~.

If you still want a better way, then submitting a new AUR package I guess, which I don't have any experience on for now. Reference PKGBUILD of python-material-color-utilities

Thanks for the reference, i can volunteer to package this.

end-4 commented 5 months ago

Alright. If you're doing it, let me know when you're done btw I'm going to note that the transition of bluetooth device when opening sideright is a bit weird

https://github.com/end-4/dots-hyprland/assets/97237370/b6f46890-9e41-497e-ac4f-682d54f6d414

midn8hustlr commented 5 months ago

I don't have any previous experience of packaging in AUR, i will try tonight, not sure if I will suceed. I will let you know how it goes.

midn8hustlr commented 5 months ago

I'm going to note that the transition of bluetooth device when opening sideright is a bit weird

Yes, I have encountered this too, idk how the bluetooth device widget is done in AGS, as I did the SCSS styling before the widget was introduced. Git somehow merged to make this work. Need to check where the delay is coming from.

end-4 commented 5 months ago

idk how the bluetooth device widget is done in AGS

no worries, i'll handle that after we have this merged

midn8hustlr commented 5 months ago

Here you go: python-materialyoucolor-git

end-4 commented 5 months ago

eyy that works

end-4 commented 5 months ago

There are many colors I wanna change, but I'll just merge this then figure it out later. Thanks!