search

end-4 / dots-hyprland

Modern, feature-rich and accessible desktop configuration.
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
3.16k stars 203 forks source link

automatically guess icons for overview #427

Open casglistro opened 2 months ago

casglistro commented 2 months ago

now overview also uses icon guessing, firstly looking based on the app name and secondly path searching.

end-4 commented 2 months ago

ugh does it work? examples? i mean i know it's the same code you had before but i realized turning the guessing on breaks my pinned stuff on dock lol

D3ja-vu commented 2 months ago

i tried it and ags dont even work giving errors like no modules named overview_hyprland eventthough i copied them

casglistro commented 2 months ago

i tried it and ags dont even work giving errors like no modules named overview_hyprland eventthough i copied them

humm, what's your terminal output?

D3ja-vu commented 2 months ago

ags Another system tray is already running Gjs-Console-Message: 23:00:47.117: [LOG] Styles loaded

(com.github.Aylur.ags:7662): Gjs-WARNING **: 23:00:47.524: JS ERROR: ReferenceError: icon_files is not defined PinnedApps/<.children<@file:///home/end-4/.config/ags/modules/dock/dock.js:195:1 PinnedApps@file:///home/end-4/.config/ags/modules/dock/dock.js:191:10 default@file:///home/end-4/.config/ags/modules/dock/dock.js:228:13 default@file:///home/end-4/.config/ags/modules/dock/main.js:11:12 forMonitors@file:///home/end-4/.config/ags/config.js:28:24 Windows@file:///home/end-4/.config/ags/config.js:56:32 @file:///home/end-4/.config/ags/config.js:79:14 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.544: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.544: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.544: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.544: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.545: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.545: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.545: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.545: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

casglistro commented 2 months ago

ags Another system tray is already running Gjs-Console-Message: 23:00:47.117: [LOG] Styles loaded

(com.github.Aylur.ags:7662): Gjs-WARNING **: 23:00:47.524: JS ERROR: ReferenceError: icon_files is not defined PinnedApps/<.children<@file:///home/end-4/.config/ags/modules/dock/dock.js:195:1 PinnedApps@file:///home/end-4/.config/ags/modules/dock/dock.js:191:10 default@file:///home/end-4/.config/ags/modules/dock/dock.js:228:13 default@file:///home/end-4/.config/ags/modules/dock/main.js:11:12 forMonitors@file:///home/end-4/.config/ags/config.js:28:24 Windows@file:///home/end-4/.config/ags/config.js:56:32 @file:///home/end-4/.config/ags/config.js:79:14 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.544: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.544: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.544: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.544: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.545: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.545: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:377:60 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-Console-CRITICAL **: 23:00:47.545: Error: There is no window named overview getWindow@resource:///com/github/Aylur/ags/app.js:138:27 update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

(com.github.Aylur.ags:7662): Gjs-CRITICAL **: 23:00:47.545: JS ERROR: TypeError: (intermediate value).getWindow(...) is undefined update@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:334:26 default/OverviewRow/setup/<@file:///home/end-4/.config/ags/modules/overview/overview_hyprland.js:398:39 hook/<@resource:///com/github/Aylur/ags/widgets/widget.js:43:25 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

thanks, I realized that I forgot to change the icon source for PinnedApps, since I didn't enable searchPinnedAppIcons so it works fine for me. Maybe I'll choose to remove this configuration