search

end-4 / dots-hyprland

Modern, feature-rich and accessible desktop configuration.
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
3.1k stars 201 forks source link

[Feature] PolKit agent #516

Open Cu3PO42 opened 1 month ago

Cu3PO42 commented 1 month ago

Let me preface this by saying this is not a feature request in the sense that I'm asking you to please do this now, I just want to document the idea and possibly start a discussion.

What would you like to be added?

I'd like to propose adding a PolKit agent to your AGS config itself. I understand you currently bundle the agent used by prior versions of Gnome, but I do believe it should be possible to build a better-looking one that integrates with the rest of the aesthetic.

How will it help

Beyond a visual uplift, it should be possible to get handling of fingerprint authentication much more correct than it currently is in Gnome Polkit agent.

Extra info

I have code for the business logic of implementing a PolKit agent in AGS on hand that I'm happy to help integrate. As for the UI, I have some ideas, but nothing concrete. The agent of modern Gnome Shell looks fairly good:

Gnome Polkit Agent

I also like 1Password's authorization dialog:

image

Maybe something similar, where instead of the 1Password icon we add the icon of the distribution.

end-4 commented 1 month ago

yeah it would be nice to have the polkit thing show up in a layershell since i want it to hog focus like in gnome thanks for reminding me that it's now possible but maybe after i make a lock screen

as for fingerprint authentication, my device doesn't have a reader so i can't test that

b4shful commented 1 month ago

This would be super cool! There are quite a few instances where I've been on Workspace 3 or something and not noticed a polkit/keyring dialog as they always seem to go to Workspace 1 haha. Usually ends in me rage quitting a program thinking it's not working, and later when I go back to workspace 1 I see the dialog and I'm like "oh ffs there's the issue" lol

Cu3PO42 commented 1 month ago

You can probably work around some of these issues, with the agent showing up on the wrong workspace or force it to take focus with some configuration of your window manager. E.g. on Hyprland you could force it to pinned and stayfocused.