end-4 / dots-hyprland

Modern, feature-rich and accessible desktop configuration.
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
3.08k stars 197 forks source link

ags: use system-wide icon theme for systray #547

Closed moetayuko closed 1 month ago

moetayuko commented 1 month ago

The system-wide gtk icon theme can be set by:

gsettings set org.gnome.desktop.interface icon-theme icon_theme_name

Don't mess up user's preference.

end-4 commented 1 month ago

I don't have Adwaita as my icon theme, but I prefer its symbolic icons. In my defense:

Though maybe we could make a config option for it if you really wanna change it. Styles are compiled at runtime so it'll probably be easy

moetayuko commented 1 month ago

I agree that Adwaita is the most accessible icon theme, but it's not complete enough.

For instance, here's my systray w/ Adwaita: before and as you can see, keepassxc and kdeconnect icons are indistinguishable from the white background. This is because Adwaita does not provide customized icons for them, and their built-in icons are selected as fallbacks, which are unsuitable for the white background.

On the other hand, they're perfectly fine when using the Papirus-Light icon theme (provides customized icons), which is designed for white background: after

In my personal setting, I use darkman scripts to set the icon theme to Papirus-Light for the light color scheme and Papirus-Dark for the dark color scheme at runtime (via the gsettings command mentioned above, gtk handles icon reload automatically so ags doesn't need to restart), which is not possible when it's hardcoded.

PS: I'm not against the use of Adwaita, but we need to fix indistinguishable tray icons, and using the system-wide icon theme is a handy solution for it.

end-4 commented 1 month ago

(via the gsettings command mentioned above, gtk handles icon reload automatically so ags doesn't need to restart)

yeah but i want to have different icon packs for symbolic and normal icons since the former in my icon pack sucks i'll implement a config option for separate icon theme for symbolic icons when i have time

moetayuko commented 1 month ago

yeah but i want to have different icon packs for symbolic and normal icons since the former in my icon pack suck

Is removing @include symbolic-icon from .bar-systray-item only acceptable to you? It will resolve my issue anyway

end-4 commented 1 month ago

added that config option

moetayuko commented 1 month ago

added that config option

thanks, is it possible to change it from cmdline w/o restarting ags?

end-4 commented 1 month ago

thanks, is it possible to change it from cmdline w/o restarting ags?

nope