end-4 / dots-hyprland

i hate minimalism so...
https://end-4.github.io/dots-hyprland-wiki/en/
GNU General Public License v3.0
3.94k stars 267 forks source link

Improvements for vertical screens #584

Open myryk31415 opened 3 months ago

myryk31415 commented 3 months ago

That fixes the logout menu not being in the center of the screen and the bar being cursed on vertical screens.

Issues:

For horizontal screens nothing should have changed. Any feedback and ideas are appreciated :)

myryk31415 commented 3 months ago

I set the threshold to 1400px so people who have some resolution lower than 1920 don't have the short bar unless necessary.

The overview is still to wide but I dont really wanna fix it rn. The rest are improvements nonetheless and there should be no changes for vertical screens so this can be merged if there are no issues.

end-4 commented 3 months ago

Good idea, but I think it could be done better

  1. Errors:
    (com.github.Aylur.ags:5589): Gtk-WARNING **: 06:48:04.209: Attempting to add a widget with type Ags_Revealer to a 
    container of type Ags_Box, but the widget is already inside a container of type Ags_Box, please remove the widget from its existing container first.
  2. Why make a "short" mode when we can just hide components of the normal bar?
  3. I think maybe there's a way to get the font size for a more educated guess whether or not we should declutter the bar
myryk31415 commented 3 months ago

Oh I didn't even think of that. Guess that's a better solution.

Using the font size and the width of the elements to check whether that's wider than the screen could be possible. Than it might be possible to hide more and more elements depending on the screen width. That would fix work as a fix for the overview as well. Imma look into it when I have time.