LuaJIT support - Githubissues

endaaman / tym

Lua-configurable terminal emulator

MIT License

185 stars 14 forks source link

Closed thalting closed 2 years ago

thalting commented 2 years ago

TODO: turn this into a build flag.

endaaman commented 2 years ago

Thanks for the PR.

I think this should be the compile option to enbale by like --enable-luajit.

thalting commented 2 years ago

how can I do this?

endaaman commented 2 years ago

What you have to do

Edit configure.ac, introduce --with-luajit option and define the flag that luajit is enabled or not.
Write LuaJIT-supported code along with the flag.
Fix Dockerfile or add new test suite for LuaJIT compilation.

thalting commented 2 years ago

i don't know how to use autotools :/

thalting commented 2 years ago

--enable-luajit by @capezotte

endaaman commented 2 years ago

--enable-luajit and USES_LUAJIT are defined but it seems LuaJIT is not actually used.

thalting commented 2 years ago

foo

ecesar88 commented 2 years ago

merge?

endaaman commented 2 years ago

I wanted the review fixed. Anyway, it is OK. I will fix it. Thanks for the PR!