enderneko / Cell

A World of Warcraft raid frame addon.
Other
92 stars 23 forks source link

Update bleedList #119

Closed Krealle closed 4 months ago

Krealle commented 4 months ago

Summary

Noticed some bleeds were missing when I was doing dungeons, so I've updated the bleedList.

In total 264 bleeds have been added and 19 have been removed. Along with some de-duplication. A list of these can be found here: https://pastebin.com/FLVBT9uK.

Methodology

Bleeds are defined by the Bleeding mechanic. Which normally would be defined by SpellEffect.EffectMechanic == 15 // Bleeding. Some bleeds will not have this flag. These can, however, be found with this flag SpellCategories.Mechanic == 15 // Bleeding

eg. https://www.wowhead.com/spell=414340/drenched-blades

However, some spells will have these flags without actually being a bleed. eg. the bleed will have triggering spells that have the same flag, or simply be flagged weirdly. So we need to make sure that our spell is an actual applied bleed SpellEffect.Effect == 6 // APPLY_AURA

eg. https://www.wowhead.com/spell=411630/throw-rat SpellEffect.EffectAura == SCHOOL_DAMAGE & TRIGGER_MISSILE https://www.wowhead.com/spell=431299/shadow-rupture SpellEffect.EffectAura == DUMMY

Ideally you would also use the flag SpellEffect.EffectAura == 3 // PERIODIC_DAMAGE But not all bleeds will have this flag (Atleast not in wago DB).

eg. https://www.wowhead.com/spell=336810/ragged-claws image

Sources

https://wago.tools/db2/SpellCategories?filter[Mechanic]=15 https://wago.tools/db2/SpellEffect?filter[Effect]=exact%3A6

enderneko commented 4 months ago

great! thanks!