search

enderneko / Cell

A World of Warcraft raid frame addon.
Other
92 stars 23 forks source link

This addon break LibGetFrame #172

Closed mrbuds closed 2 months ago

mrbuds commented 2 months ago

https://github.com/enderneko/Cell/blob/3900c7496b2462dc48d996fe42f1ad9a5779c794/Utils.lua#L2213 replace LibGetFrame functions

If you want to improve LibGetFrame you are free to contribute, but replacing functions like this is not acceptable. This is forcing me to take steps to not let your code break mine.

enderneko commented 2 months ago

Okay, if you got mad with this, I can remove this. But I don't get it, what do you mean by "break"? If people use this addon (Cell), they want these WA showing on correct frames, right? And this feature can be turned off in Cell options.

I understand it's free to contribute. In my opinion this is an addon-specific feature, should not be added to that Lib which provides a generic solution.

I'll remove this, and find a way around. Or I fork your lib and embed it into Cell. (And make my changes.) way found

enderneko commented 2 months ago

Please show me the way. I'm always prepared to listen.

enderneko commented 2 months ago

05a26c3a8f0d35aeb7856c5df92fd42d8e143201 removed.

enderneko commented 2 months ago

https://github.com/enderneko/LibGetFrame/commit/6642d7b6594a7569f795a79e3207dc135c976b68 @mrbuds how about this? If it's okay, I'll do it in this way, then create a PR.

enderneko commented 2 months ago

@mrbuds Updated. Will create a PR.