search

enebo / Purugin

Ruby Minecraft Plugin support on top of bukkit
238 stars 32 forks source link

A ton of changes. Build changes. A bug fix. #27

Closed ericanderson closed 12 years ago

ericanderson commented 12 years ago

This sets up the world to use maven, which actually seems to work at the command line where the ant script wasn't.

I also fix an issue in block.destroy! where it threw an exception.

enebo commented 12 years ago

Thanks Eric. I loathe the extra directory nesting that maven's conventions use, but I think I will roll with it on these moves. I keep fighting Maven conventions and I think I should just accept them. :)

The other thing worth thinking about is I was just stuffing a Purugin.jar into the root as a testable jar for those who are not developers (e.g. don't have ant or maven installed). I could always add it to Downloads like I do with release values. Perhaps update install to allow --pre or something like that.

ericanderson commented 12 years ago

Now that it's maven you can get it in travisci and direct people to the latest build that way and utilize githib downloads for official releases

--Eric Anderson

Sent from a mobile device

On May 29, 2012, at 7:00, Thomas E Enebo reply@reply.github.com wrote:

Thanks Eric. I loathe the extra directory nesting that maven's conventions use, but I think I will roll with it on these moves. I keep fighting Maven conventions and I think I should just accept them. :)

The other thing worth thinking about is I was just stuffing a Purugin.jar into the root as a testable jar for those who are not developers (e.g. don't have ant or maven installed). I could always add it to Downloads like I do with release values. Perhaps update install to allow --pre or something like that.

Reply to this email directly or view it on GitHub: https://github.com/enebo/Purugin/pull/27#issuecomment-5984182

ericanderson commented 12 years ago

Also. A license file would be helpful. MIT? Apache?

--Eric Anderson

Sent from a mobile device

On May 29, 2012, at 7:00, Thomas E Enebo reply@reply.github.com wrote:

Thanks Eric. I loathe the extra directory nesting that maven's conventions use, but I think I will roll with it on these moves. I keep fighting Maven conventions and I think I should just accept them. :)

The other thing worth thinking about is I was just stuffing a Purugin.jar into the root as a testable jar for those who are not developers (e.g. don't have ant or maven installed). I could always add it to Downloads like I do with release values. Perhaps update install to allow --pre or something like that.

Reply to this email directly or view it on GitHub: https://github.com/enebo/Purugin/pull/27#issuecomment-5984182

enebo commented 12 years ago

Ah yeah that's true. I had not thought about it from the travis-ci angle at all and it would solve the snapshots issue quite nicely.

HEH...yes a license would be a good idea wouldn't it? :) I will add LICENSE file for Apache and then contact everyone to make sure they are cool with that.

ericanderson commented 12 years ago

Im playing with the travis-ci piece on my fork.

Looks like it worked amazingly. Will give you a pull request assuming its good.

-EA

On May 29, 2012, at 1:38 PM, Thomas E Enebo wrote:

Ah yeah that's true. I had not thought about it from the travis-ci angle at all and it would solve the snapshots issue quite nicely.

HEH...yes a license would be a good idea wouldn't it? :) I will add LICENSE file for Apache and then contact everyone to make sure they are cool with that.

Reply to this email directly or view it on GitHub: https://github.com/enebo/Purugin/pull/27#issuecomment-5995079

ericanderson commented 12 years ago

Also, check out the icon on my read me.

https://github.com/ericanderson/Purugin/blob/master/README.md

On May 29, 2012, at 1:38 PM, Thomas E Enebo wrote:

Ah yeah that's true. I had not thought about it from the travis-ci angle at all and it would solve the snapshots issue quite nicely.

HEH...yes a license would be a good idea wouldn't it? :) I will add LICENSE file for Apache and then contact everyone to make sure they are cool with that.

Reply to this email directly or view it on GitHub: https://github.com/enebo/Purugin/pull/27#issuecomment-5995079

enebo commented 12 years ago

hah...looks awesome. The only thing which makes that not so interesting is the pathetically small set of tests :)

ericanderson commented 12 years ago

True dat. Also, it looks like Travis won't give you artifacts. But we could hack up some maven to upload alpha jars to github's download page…

On May 29, 2012, at 4:28 PM, Thomas E Enebo wrote:

hah...looks awesome. The only thing which makes that not so interesting is the pathetically small set of tests :)

Reply to this email directly or view it on GitHub: https://github.com/enebo/Purugin/pull/27#issuecomment-5998674