search

enejb / bowen.today

Git repo behind bowen.today
http://bowen.today
GNU General Public License v3.0
1 stars 2 forks source link

Initial styles for header and components #10

Closed giorgioriccardi closed 3 years ago

giorgioriccardi commented 3 years ago

I added few styles, normalize css, and moved template parts in the header.php.

Created header-home.php as a temporary patch, will be built as a condition if is_home() type.

Your styles did not get pulled from the style.sass into my repo, I add to add them manually. To be investigated!

enejb commented 3 years ago

Thanks for the chanegs. I noticed a couple of things.

  1. The button background colours don't match the header any more. There seems to be slight difference.
  2. The main width is a bit too big. Which makes the row a bit too wide. Maybe we can set a the max width to 800. so that it doesn't stretch much further?
  3. There is always a margin on side now on small screens can we remove that?

Thanks for all your work on this refactor.

giorgioriccardi commented 3 years ago

Thanks for the chanegs. I noticed a couple of things.

1. The button background colours don't match the header any more. There seems to be slight difference.

2. The main width is a bit too big. Which makes the row a bit too wide. Maybe we can set a the max width to 800. so that it doesn't stretch much further?

3. There is always a margin on side now on small screens can we remove that?

Thanks for all your work on this refactor.

  1. The BTN bg is different because I wanted to flash it to the container
  2. The main width is set for testing to 75vw, probably 65vw is what we need
  3. I did not test properly on mobile
  4. I'll push a different PR tomorrow!