search

enonic / doc-starter-react4xp

Documentation for the starter-react4xp project
0 stars 0 forks source link

Make target id in example 2 a constant passed to thymeleaf #5

Closed ComLock closed 4 years ago

ComLock commented 5 years ago

It should be possible to make the target id a constant in javascript and pass that to thymeleaf render. I think that is nicer than "hardcoding" it two places.

espen42 commented 5 years ago

Nicer and better XP practice, but not clearer here. I think tutorials should never add complexity or stuff going on if it's not needed and doesn't show any part of what you're trying to teach.

(I may have broken that promise somewhere else, but I feel like keeping this one as-is)