search

entomb / dragonchan

A prototype script to transform any /b/ thread into a dragon slaying match.
24 stars 17 forks source link

ENRAGED bug fix #7

Closed tselaty closed 11 years ago

tselaty commented 11 years ago

Fixed bug where when the Boss ENRAGED, the "break" clause in the IF statement exited out of the script entirely. Added ENRAGED block to underneath the Boss HP bar when he's ENRAGED for a better experience and excitement.

entomb commented 11 years ago

Deployed!

entomb commented 11 years ago

That break; is blocking the whole log bellow the enrage line. is this intended?

tselaty commented 11 years ago

Correct. It sets the new bar for the remainder of the battle, such as "entering the final phase". There can be several hundreds entries after it, which isn't nearly as fun to follow or have to scroll to meet. Once a boss enrages, the log show show new entries above the enragement.

Previously, there was nothing showing after the enragement. If a boss was enraged, the whole page would exit out, show nothing after the enragement, and not even show the sidebar with the recent or top activity for some reason. I assumed since you already have the "continue" statement, your intention was not to exit out of the script, but truncate the visible log after the ENRAGEMENT.

entomb commented 11 years ago

I think the post should stay so people can target the dead and also inspect their damage and hits when the thread ends. this becomes obscure when they disapear.

shouldn't we put the enrage reminder bigger and let the posts underneat stay?

tselaty commented 11 years ago

Sure. I can understand that. If you remove the "break" clause, that should resume the script as normal.