Code review

[talantbekov123]

Hello! I'm sorry for the review delays. Because of large files uploaded to the tracker I can not make a review. Please remove request.log/error.log files and build/static folders before submission. Also, node_modules that are stored here https://github.com/enyelsequeira/react-around-api-full/tree/main/front-end/node_modules may be the reason. Next submission please make sure that all large files are cleared.

Regarding the question addressed to me, now I have even more than before? it is not always possible to detect certain errors until previous comments are fixed. Bellow are the final comments and you have 1 review left. Please make sure all comments under Needs correcting block are fixed. You've put a lot of work into this! I will be happy to assist you in case you have any questions.

https://pasteboard.co/JCqo48v.png reviewed your profile as well, looks awesome! Hope you will achieve all your goals!

Needs correcting:

• Please fix ESLint errors (you can see them by running npx eslint ./ in the backend directory. The screen here https://pasteboard.co/JCq2SdY.png. Code editor should highlight all style mistakes. Let me know if you have any questions.
• When trying to delete a card with a valid id but it is not in the database, the service returns an incorrect response. Try to remove the same card twice. The server always responds with status 200. Screen https://pasteboard.co/JCqaJS3.png. https://pasteboard.co/JCqcKlk.png This part of the code is not correct. Node is an asynchronous platform, it will run both blocks in parallel. I would recommend something like this, instead.

  const deleteCard = async (req, res, next) => {
  Card.findById(req.params.cardId).then((card) => {
  if (card === null) {
    throw new NotFoundError("card not found");
  } else if (String(card.owner) !== req.user._id) {
    throw new ForbiddenError("User is not authorized for this method");
  } else {
    Card.findByIdAndDelete(req.params.cardId)
      .then(() => res.send({ message: "Card deleted" }));
  }
  }).catch(next);
  };

• Screen https://pasteboard.co/JCqhh8i.png. Joi/celebrate errors should return status 400 instead of 500. All validation errors should return status 400, more details related to status code can be found here https://airbrake.io/blog/http-errors/400-bad-request#:~:text=The%20400%20Bad%20Request%20Error,client%20due%20to%20invalid%20syntax.

There are some comments for improvement. They don't mean that you did anything wrong, but they're things we wanted to point out that can help you further develop your skills.

• it is not good practise to return "[object Object]", better to return custom string. Screen https://pasteboard.co/JCq96l3.png
• The uri() validator you use to validate links skips incorrect values, in particular, http:ya.ru. Instead, I recommend that you use the Joi custom validator. More details here https://github.com/sideway/joi/blob/master/API.md#anyvalidatevalue-options. I can also advise you to check for these valid URLs before submitting (may be helpful for the diploma). http://ya.ru https://www.ya.ru http://2-domains.ru http://ya.ru/path/to/deep/ http://ya-ya-ya.ru And not valid too, for example http: // yandex http: // ya! ~ ndex.ru

[talantbekov123]

You've done a really good job! There is a tiny comment that needs to be done before your project can be accepted. Hope this will be an easy fix for you! Comments based on the project send my Liza Belyaeva, not current Github repository. This is your last iteration.

Needs correcting:

• Please fix ESLint errors (you can see them by running npx eslint ./ in the backend directory. The screen here https://snipboard.io/ksG5n0.jpg. Code editor should highlight all style mistakes. Let me know if you have any questions.

There are some comments for improvement. They don't mean that you did anything wrong, but they're things we wanted to point out that can help you further develop your skills. (comment below will be important for diploma)

• When creating a user with an email that already exists in the database, you must return an error with the status code 409 (Conflict) instead of 403. Screen https://snipboard.io/4RhwAY.jpg. Also, instead of returning a response directly, it should throw an appropriate exception. https://snipboard.io/4RhwAY.jpg