enzet / map-machine

Python renderer for OpenStreetMap with custom icons intended to display as many map features as possible
MIT License
514 stars 34 forks source link

Draw railways under construction #125

Closed Zero3 closed 2 years ago

Zero3 commented 2 years ago

This would be useful in my opinion. OSM shows them as well.

Example: https://www.openstreetmap.org/way/926175220

enzet commented 2 years ago

Hello, @Zero3. Do you think this is fixed?

Zero3 commented 2 years ago

Seems like you did not update the python3.8 branch with the change, but I copy-pasted it in manually on my machine, and it looks pretty nice.

However, the railways under construction now look more prominent than the already built railways. The under construction ones are darker and wider. I think the widths should be similar instead, and the existing railways at least as dark as the ones under construction.

Zero3 commented 2 years ago

Forget the last part of my comment above. I applied the change incorrectly to my local config at first.

New thoughts: Looks pretty good overall. However, they are drawn beneath roads and buildings, which looks a bit odd (note that I made building a bit transparant in this screenshot - normally they are solid):

image

I would prefer if they were drawn on top, I think? Also, I think stroke-dasharray: 15,5 would be a bit better. I think longer strokes make it look more intuitive:

image

Perhaps reducing the width 2 instead of 3 could be considered too.

Anyway, these are just suggestions. I will let you figure out what you want to go with :).

enzet commented 2 years ago

Hi, @Zero3!

Yes, I think rails should definitely go above roads. However I'm not sure about buildings. I sometimes make building layer transparent too. Probably, there should be a command line options for this.

Size of dashes was quite arbitrary, your suggestion looks better.

enzet commented 2 years ago

I want to fix what we have for now and then decide what kind of overlapping we want for roads and railroads.

This is Map Machine rendering for now:

overlap

enzet commented 2 years ago

After

overlap

enzet commented 2 years ago

Hope this issue is done. Feel free to reopen it if I'm wrong.