search

enzet / map-machine

Python renderer for OpenStreetMap with custom icons intended to display as many map features as possible
MIT License
515 stars 34 forks source link

waterway=river is hidden behind natural=wood #126

Closed Zero3 closed 2 years ago

Zero3 commented 2 years ago

Example: https://www.openstreetmap.org/way/258695030

Can be fixed by setting priority to 22, since natural=wood has priority of 21. I did not consider if the priority should be even higher.

enzet commented 2 years ago

You're right. Thank you.

enzet commented 2 years ago

I set the priority of waterways to 22. But I really don't like this priority solution. Really counter-intuitive. I have to refactor this or at least add some checks.

Notes for me: command is map-machine render -c 55.43238,10.29241 -s 800,600

enzet commented 2 years ago

Hi, @Zero3! I've added a test for this, so as not to break the order if I want to refactor priority.

Could you please close this issue if you think it's done.

Zero3 commented 2 years ago

Thanks. I will have a look once these changes arrive in the python3.8 branch.

enzet commented 2 years ago

Hi, @Zero3! Sorry for the late response. I've updated the branch, fixed Python version in documentation, and increased the project version. Could you please take a look and tell me if I forgot something.

Zero3 commented 2 years ago

No worries! Thanks for the fix. I will check it when I get back to my map project. It might take a little while, but I will make sure to check it once I get back to it! :)

enzet commented 2 years ago

Hope this issue is done.

Zero3 commented 1 year ago

Sorry I did not get time to re-test this in a reasonable timeframe. Good idea to close this - I can always create a new issue if I run into the problem again :+1:. Thanks again for fixing.