Adding labels to roads (proposal)

enzet / map-machine

Python renderer for OpenStreetMap with custom icons intended to display as many map features as possible

MIT License

503 stars 31 forks source link

Adding labels to roads (proposal) #127

Closed aklofas closed 1 year ago

aklofas commented 2 years ago

Include calculations to repeat road names for long roads

aklofas commented 2 years ago

Example of the implementation pineridge

enzet commented 2 years ago

Hello, @aklofas!

Wow, this is just wonderful! Thank you for the request.

aklofas commented 2 years ago

Yeah some of the code is messy. This was just a proposal to get the ball rolling on a possible implementation. It's clear that to get this feature implemented right, we'll need:

Get the real width of the label with font+size
Add scheme style support
Ability to switch on and off (argparse?)
Flip text (or reverse paths) so labels aren't upside down sometimes
Combine segmented paths for continuous labels (some roads are split several times)
(optional) avoid putting labels on tight corners
probably more...

Overall this a great project and I'm still poking around the code understanding everything you've done. A lot of hard creative work went into this and it really shows!

enzet commented 2 years ago

Yeah, the list is almost what I have in mind on this issue. And I think there is a more challenging task to get rid of overlapping between labels by moving them along the lines.

^_^ Thank you very much for such a review! This is really motivating!

enzet commented 2 years ago

Hello, @aklofas,

I would really like to merge this request and continue to improve labels for ways. Could you please fix code style, so that I can do that?

The easiest way is to

pip install black flake8,
run black -l 80 map_machine (it will fix code style automatically),
run flake8 --max-line-length=80 --ignore=E203,W503 map_machine (it will list some code style errors),
and fix some line lengths.

Thank you!