Data download does not work

enzet / map-machine

Python renderer for OpenStreetMap with custom icons intended to display as many map features as possible

MIT License

514 stars 34 forks source link

Data download does not work #152

Open mfbehrens opened 1 year ago

mfbehrens commented 1 year ago

When I try to run it, it says: "Cannot download data."

Maybe there has been an update in urllib3.

Changing osm/osm_getter.py lin 74 from result = pool_manager.request("GET", address, parameters) to result = pool_manager.request("GET", address, fields=parameters) fixed it for me

fazalmajid commented 1 year ago

urllib3 2.0 creates all sort of breakage, some distros like Alpine Linux have chosen to revert. Thanks for the resolution!

enzet commented 1 year ago

Oh, I see, there is new syntax in urllib3 version 2 for request() function and I have urllib3>=1.25.6 instead of urllib3~=1.25.6 in requirements.txt file. I will fix that (probably not upgrading to version 2 because of @fazalmajid comment).

@mfbehrens99 Could you please create a pull request, or send me a patch, or at least provide your name/email so that I can apply the patch in your name?

eliandoran commented 7 months ago

@enzet , would it be possible to carry on with this fix? I've just had the same issue. I see there is a PR handling this in #157. With that fix applied, everything seems to work fine.