enzolutions / community-bookstore

Community Bookstore to exchange and donate books
10 stars 18 forks source link

Bootstrap Carousel doens't work #6

Closed enzolutions closed 10 years ago

enzolutions commented 10 years ago

The original design has a Carousel, but for some reason is not working after combine de CSS, confirm with @omero where are te resources.

igasi commented 10 years ago

@omero which library is being used to define the carousel? i think is missing. only i found referencias in .sass-cache and content.html.twig files.

omero commented 10 years ago

@igasi i use the default carousel of bootstrap ,it only used the bootstrap.js & jquery libraries (BTW they're referenced), in theory to make it work, only i have to specify the data-ride="carousel" attribute like this https://github.com/enzolutions/community-bookstore/blob/master/frontend/web/templates/content.html.twig#L1 and the carousel has to work, when i was making the home page in other project, it works great, but in this project not, the worst part is that not showing me any errors u_u

omero commented 10 years ago

@igasi i think that we have the solution for the problem, can you check if this works of your side ?

define([
  'backbone',
  'application',
  'jquery',
  'bootstrap'
],
function (Backbone, App, $) {
    $('#carousel-home').carousel();
    $('#carousel-testimonials').carousel();
});

if it works please make the PR, i have other functionality to add in this file :)

igasi commented 10 years ago

Thanks @omero, i created PR and sent to @enzolutions

enzolutions commented 10 years ago

Resolved by @igasi