search

ephread / inkgd

Implementation of inkle's Ink in pure GDScript for Godot, with editor support.
MIT License
317 stars 33 forks source link

Removed icon_folder #17

Closed 2shady4u closed 4 years ago

2shady4u commented 4 years ago

Checklist for this pull request

Description

Building a project that uses inkgd with the help of godot-ci gives several errors because of the icon_folder.SVG which, for some reason, cannot by loaded.

I don't know the exact cause of these errors, but the icon_folder can actually be removed since the editor folder icon can be accessed directly. (By using get_icon("Folder", "EditorIcons"))

DON'T MERGE YET, STILL HAVE TO VERIFY CI BEHAVIOUR AND DO ADDITIONAL TESTS!

ephread commented 4 years ago

but the icon_folder can actually be removed since the editor folder icon can be accessed directly. (By using get_icon("Folder", "EditorIcons"))

Amazing, I didn't know about this. That's clearly the way to go, thanks!

DON'T MERGE YET, STILL HAVE TO VERIFY CI BEHAVIOUR AND DO ADDITIONAL TESTS!

Sure thing, I've marked this a WIP.

2shady4u commented 4 years ago

Hey @ephread !

Sorry, I seem to have forgotten about the existence of this PR :/ I've been using the same tactic (using the edit folder icon) in one of my other repositories and haven't encountered any errors.

Also for completeness' sake here's a project that enables the user to browse and search for other editor icons: https://github.com/pycbouh/godot-editor-theme-explorer

TLDR: You can safely merge this if you want.

ephread commented 4 years ago

Sorry, I seem to have forgotten about the existence of this PR :/

No worries :)

Also for completeness' sake here's a project that enables the user to browse and search for other editor icons: https://github.com/pycbouh/godot-editor-theme-explorer

Great stuff, they'll get a star. ⭐

TLDR: You can safely merge this if you want.

Perfect!