search

ephread / inkgd

Implementation of inkle's Ink in pure GDScript for Godot, with editor support.
MIT License
305 stars 33 forks source link

Update INK_VERSION_CURRENT to 20 #30

Closed bkmeneguello closed 2 years ago

bkmeneguello commented 3 years ago

INK_CURRENT_VERSION is currently defined as 19 but ink's inkVersionCurrent is 20

ephread commented 3 years ago

Hey @bkmeneguello inkgd doesn't support stories compiled with inklecate 1.0.0 yet. I'll update the version once I port over all the changes!

bkmeneguello commented 3 years ago

I'm using this version without problems (yet), I can even run "The Intercept" compiled by Inklecate 1.0.0 with all flows. I didn't tested newer features yet.

videlanicolas commented 2 years ago

I think we need to bump this version to 20. While doing some test runs of Inkgd I'm getting this same error.

I'd say we bump the version, and if there are incompatibilities between Ink and Inkgd they should be filed as bugs.

ephread commented 2 years ago

I'd say we bump the version, and if there are incompatibilities between Ink and Inkgd they should be filed as bugs.

I'm not keen on doing this because it sounds like a maintenance nightmare down the line.

Fortunately, the migration to 1.0.0 is nearly completed. I just have to dig into the codebase and find why 2 tests are crashing and 4 tests are not passing. I should be able to release the next version over the weekend or early next week.

ephread commented 2 years ago

Fixed by #49.