Example usability and editor variables

ephread / inkgd

Implementation of inkle's Ink in pure GDScript for Godot, with editor support.

MIT License

305 stars 33 forks source link

Example usability and editor variables #50

Closed makeartandgames closed 2 years ago

makeartandgames commented 2 years ago

Some QoL changes to the example ink_runner.gd os-dependent loading, export and make variable: start knot, json file…

Progresss

[x] Move observed variables into an array exported to the editor
[x] Move ink json resource into an editor variable
[x] Move starting knot into an editor variable and allow it to be null (for when the ink file diverts at file scope)
[ ] Double check that it works
[ ] switch to OS.has_feature?

ephread commented 2 years ago

Hey @makeartandgames, thanks for the work! I won't accept this PR, though, because I'm the process of completely reworking how to interact with inkgd.

There's going to be a node, from now on, that exposes certain properties and the JSON file will be a proper resource.

I'm still going to take cues from this PR, especially regarding the thread problem on HTML5 export. I'll mention you when it's done so you can have a look and suggest changes if that doesn't solve most of the issues.

ephread commented 2 years ago

Feedback welcome about the new InkPlayer node and the new The Intercept scene!