ephread / inkgd

Implementation of inkle's Ink in pure GDScript for Godot, with editor support.
MIT License
305 stars 33 forks source link

inkgd not compatible with Godot 4.2 #76

Closed francoisdlt closed 10 months ago

francoisdlt commented 11 months ago

Describe the bug When running inkgd in Godot 4.2.beta1, I get the following error :

res://addons/inkgd/runtime/values/value.gd:104 :
Parser Error: The function signature doesn't match the parent. Parent signature is "copy() -> Variant".

To Reproduce Install Godot 4.2.beta.1 with the godot4 version of the plugin

Expected behavior No error :)

Ink files Irrelevant

Environment:

nyxkn commented 10 months ago

I changed copy() to return Variant, and that seems to fix this. Both in ink_object.gd and in value.gd.

func copy() -> Variant:

ephread commented 10 months ago

Thanks @nyxkn and @francoisdlt, I'll fix this!

ephread commented 10 months ago

Fixed by 470c734.