search

ercius / openNCEM

A collection of packages and tools for electron microscopy data analysis supported by the National Center for Electron Microscopy facility of the Molecular Foundry
GNU General Public License v3.0
60 stars 28 forks source link

SER array size backwards #10

Closed ercius closed 7 years ago

ercius commented 7 years ago

The ser reader code does not work for non-square images. I think that the values in reshape() in line 380 in getDataset() need to be swapped.

fniekiel commented 7 years ago

That's quite possible, I never had the chance to try non-square images ... Can you take care of it?

ercius commented 7 years ago

Yes. Will do!

On Sun, Aug 13, 2017, 10:56 AM fniekiel notifications@github.com wrote:

That's quite possible, I never had the chance to try non-square images ... Can you take care of it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ercius/openNCEM/issues/10#issuecomment-322056679, or mute the thread https://github.com/notifications/unsubscribe-auth/AO7olKBVvmQP1CdTkvPymouk8nVQy1MUks5sXzi2gaJpZM4OuOqA .

ercius commented 7 years ago

Ok. I changed the ser.py file to use the reverse ArraySize. I left everything else the same though. We may need to change everything with respect to the dimensions (pixel size, reported array size, dim vectors in writeEMD, etc.)