ercius / openNCEM

A collection of packages and tools for electron microscopy data analysis supported by the National Center for Electron Microscopy facility of the Molecular Foundry
GNU General Public License v3.0
58 stars 28 forks source link

kwargs for enabling compression on datasets in emd files. #15

Closed ZGainsforth closed 5 years ago

ZGainsforth commented 5 years ago

A user can pass in compression or any other kwargs to create_dataset() if he wants to.

ercius commented 5 years ago

@ZGainsforth Can you add the **kwargs to the docstring? Then users will know that they can pass additional parameters to h5py.create_dataset.

ZGainsforth commented 5 years ago

Done.

ercius commented 5 years ago

Thanks for getting this added!

ZGainsforth commented 5 years ago

You’re welcome!

On Jun 3, 2019, at 11:44 AM, Peter Ercius notifications@github.com wrote:

Thanks for getting this added!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ercius/openNCEM/pull/15?email_source=notifications&email_token=ABUL524ZHXEQCTZ4JKPHIY3PYVRCNA5CNFSM4HL5PFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2KK2I#issuecomment-498378089, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUL52YHKP42HTQ53QAWC3LPYVRCNANCNFSM4HL5PFGQ.