search

ercius / openNCEM

A collection of packages and tools for electron microscopy data analysis supported by the National Center for Electron Microscopy facility of the Molecular Foundry
GNU General Public License v3.0
55 stars 27 forks source link

add dm4 and new path in writeTags method #26

Closed koschie closed 3 years ago

koschie commented 4 years ago

Hi, i was using your great library to read dm4 files and i love the writeTags method, except i use dm4s not dm3 and i thought it might be a functionality more people would like. I used to just copy your source code and modify it a bit for my scripts. I hope you find it useful enough to write it in your package. I also added a bit about being able to save the tags file in a different location in case it's useful for some people.

ercius commented 3 years ago

@koschie Thanks for the pull request! I wrote this function a long time ago, and never updated it to include DM4 files. Ill merge this in. Thank you for contributing.

ercius commented 3 years ago

@koschie I made some updates to your code to use pathlib.Path to simplify the file creation process. This will be released in the next ncempy release soon. Thanks again!