search

ercius / openNCEM

A collection of packages and tools for electron microscopy data analysis supported by the National Center for Electron Microscopy facility of the Molecular Foundry
GNU General Public License v3.0
60 stars 28 forks source link

DM import can't read newest-version files #32

Closed elifino closed 3 years ago

elifino commented 3 years ago

It looks like Gatan changed the encoded type of tag "Acquisition Time (OS)" from type 7 (float64) to the very rarely used type 11 (int64) in a recent version change. This means fileDM cannot open these files since it doesn't include type 11 in all its lists.

I've tried a very quick fix and it seems to work: Add the entry 11: 8 to self._encodedTypeSizes

I don't have a large enough set of test cases to verify that this works generally. I would be happy to provide an example file where the current version fails.

ercius commented 3 years ago

Thanks for the bug report! int64 is becoming an important data type as data sets get larger and larger. Ill add this in soon and try to figure out a way to test for it.