search

erdl / thermal_comfort

Algorithms for Thermal Comfort Prediction using PMV and Adaptive Method.
2 stars 1 forks source link

commented out UNIX platform specific code and added a CRAN mirror … #4

Closed ryantanaka closed 6 years ago

ryantanaka commented 6 years ago

Made some changes that allowed this to work on a Windows platform.

For some reason, V8 had to be manually installed.

ryantanaka commented 6 years ago

hey @carlosparadis , i see you closed #8 there is a conflict on those small changes I made now. what's the plan with #3, shall we close it?

carlosparadis commented 6 years ago

@ryantanaka I was organizing the folders, this may be why it is conflicting :( I did not edit the code. Any chance you could fix the conflict? You should just need to copy and paste the entire code over the same script inside the pmv folder. I am surprised it led to a conflict! #8 was closed as won't fix because the pipeline Eileen wanted was dropped, but no point in wasting the effort already put in making this code work on windows.

ryantanaka commented 6 years ago

@carlosparadis , ohh right that might be the case instead of going through that just to submit the PR shouldn't we just close #3 and cancel this PR? your code is good to go already right?

carlosparadis commented 6 years ago

@ryantanaka you can send another PR if you like, but the code on the current pmv file on github is the same you saw when you git clone to eileen computer. You need to re-send the file you have on another PR so I can accept :(