search

erich666 / Mineways

Exports models from Minecraft for 3D printing or rendering
http://mineways.com
Other
408 stars 60 forks source link

Waterlogged stairs sometimes end up oriented incorrectly #68

Closed ChlorideCull closed 3 years ago

ChlorideCull commented 3 years ago

Found this when trying to make a world to export. Those stairs are supposed to hug the wall.

Example: Example image

Here's an export and world: repro_export.zip repro_world.zip

erich666 commented 3 years ago

Waterlogging is definitely a flaky feature in Mineways. Thanks for reporting this, I'll take a look at it soon. I admit to being a bit Mineways-out, after having worked like crazy to get 8.00 and 8.01 out this week.

ChlorideCull commented 3 years ago

Oh yeah, no rush, I'm having great fun. As a side note, a feature request: I'd love for them to not be waterlogged if there's a change block command that replaces water with air, or through a change block command. Right now I have to remove them manually in Blender afterwards.

erich666 commented 3 years ago

Whew, fixed. Had nothing to do with waterlogging, but rather that the stairs orientation code has been using the old, pre-1.13 "what's my neighbor?" rules for deciding whether to add or subtract a sub-block from the stair block.

I finally switched over to reading in the stairs' 1.13+ properties and using them directly to determine if it's an "inner" or "outer" stairs, and left or right. This had the unforunate side effect that I had to redo 19 newer stairs, assigning each of them a separate "type" ID number internally, which hastens the day when I run out of numbers (511 is the maximum) and the code base can no longer be updated to new versions of Minecraft. We'll see how long these numbers last...

Anyway, fixed, and you can download the beta with this fix.