karkabbage
commented
9 months ago - @erikaliang520 I think it's still appropriate that your history use case is its own seperate panel and at the core, will only have the original and translated word. If you wanted to leave the option for extending this, would using the WordFactories witih Original and Translated speicalized create methods be useful? Should our use cases be creating these new entities?
- @sophieebyr Will using the TranslatedWord make sense in your case? currently it additionally stores the file path to find the audio file. Will this be useful moving forward with what you have so far and from #12 , does it always have to save in your files?
- I find it odd still that original class and translated class at their basic level are the same classes, since only the inner attributes will change @erikaliang520 , how should we modify this once your history use case is all working or should we continue this class implementation with how the factories work?
- To prepare for extension and future features, @AddisonLuo04 although it might not be used now, do you think making a language attribute for input boundary would be reasonable? I'll add this part to my code review for your Translation pull request