erin-fitzpatric / next-aom-gg

https://aom.gg
16 stars 12 forks source link

Recorded Games Team Support #90

Open erin-fitzpatric opened 2 months ago

erin-fitzpatric commented 2 months ago

Right now the recorded games page only supports 1vs1 games.

  1. Update the uploading and parse process to allow for team games. I believe the parser should already work for parsing team games. @Logg-y would know more about that.
  2. Edit or create new front end components to display team games in an elegant way. Much of this was already designed in a reusable way for team support...hopefully!
  3. We will never show teams and 1v1 games next to each other in the UI. Create a filter dropdown to allow for 2v2, 3v3, 4v4 etc. Maybe add some "standard" options and then maybe a catch all for "others" since there can be tons of different combos.
  4. query param should be added for gameType or whatever so that the filter is applied if a user links the recs page with the team filter. Something like: https://aom.gg/recs?type=2v2

Join the Discord for more info and an example game to test uploads: https://discord.com/channels/534472908765134849/1284050679047913492/1285248751442595892

Definition of Done:

Logg-y commented 2 months ago

The parser should be nearly good to go on this - once #56 is merged the TODO marked block that throws the UNSUPPORTED_GAME_SIZE error can just be removed. Only thing that I can think of that might need investigating is the whole lobby setting for free for all and whether the parser still reads team ids correctly with that setting enabled. I should be able to test that though.

Logg-y commented 1 month ago

Parser PR is up now, enabling team game upload should be as simple as deleting these three lines.

I still haven't tested the FFA lobby setting thing, though...