erlef / setup-beam

Set up your BEAM-based GitHub Actions workflow (Erlang, Elixir, Gleam, ...)
MIT License
373 stars 50 forks source link

Add support for Ubuntu 24 #271

Closed sax closed 3 months ago

sax commented 3 months ago

Description

As of right now, the only packages available for OTP 27 are only available for Ubuntu 24.04. The setup-beam action only supports Ubuntu 22 or earlier.

These changes seem to work for me, though I am currently unable to run the tests... will add more info in the comments.

Closes #270.

sax commented 3 months ago

When I try to run the tests locally, I get the following error:

::error::Error: Got an exception when trying to parse non-JSON list {"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"}: Error: expected a list!

I don't see any information in the README or in the code about how to set up the project for running tests locally, but am happy to do so if someone can point me in a good direction.

ericmj commented 3 months ago

When I try to run the tests locally, I get the following error

You may have to generate a github access token [1] and set GITHUB_TOKEN.

[1] https://github.com/settings/tokens

ericmj commented 3 months ago

Can you add ubuntu-24.04 to the matrix here? https://github.com/erlef/setup-beam/blob/main/.github/workflows/ubuntu.yml

ubuntu-latest currently points to ubuntu-22.04.

@paulo-ferraz-oliveira Should we be explicitly with the ubuntu version instead of using latest?

sax commented 3 months ago

Awesome, GITHUB_TOKEN was the thing I was missing. I may issue another pull request adding a reference to that in the README.

@ericmj One thing that I ran into today is that there are no Elixir builds yet for OTP 27 in builds.hex.pm. Do you have a preference for how many OTP versions (and which versions) I add to the matrix?

ericmj commented 3 months ago

One thing that I ran into today is that there are no Elixir builds yet for OTP 27 in builds.hex.pm.

The builds were delayed but are available now.

Do you have a preference for how many OTP versions (and which versions) I add to the matrix?

No, I would defer to @paulo-ferraz-oliveira here.

sax commented 3 months ago

Ok, based on the CI failures and looking deeper at the test suite I just reran the tests locally in an Ubuntu container in docker.

sax commented 3 months ago

Also to be very transparent I'm totally happy with anybody updating these changes, or throwing them away in favor of something else if that's decided to be better. Attribution is nice, but being able to update my apps to OTP 27 would be very nice 😄.

paulo-ferraz-oliveira commented 3 months ago

The proposed changes seem sane to me.

the only packages available for OTP 27 are only available for Ubuntu 24.04

What does this mean? From builds.txt? I think in the meantime more stuff is available, if that's the case.

sax commented 3 months ago

Cool! Decided to apply your suggestions as a single commit, vs 3 commits via the GitHub UI.

the only packages available for OTP 27 are only available for Ubuntu 24.04

Yeah looks like this was just an issue yesterday, and built are coming out for the different platforms. So not a real issue, just an explanation of why I chose to open this PR yesterday.

paulo-ferraz-oliveira commented 3 months ago

So not a real issue, just an explanation of why I chose to open this PR yesterday.

No prob. Now we're ubuntu24 ready, too 🤗. I'm gonna do some FOSS related to OTP 27 today, still, and it's possible I release the action's new version later (today, still). If I don't kindly remind my by commenting on this pr.

paulo-ferraz-oliveira commented 3 months ago

Thanks for the PR.