search

esanchezros / quickfixj-spring-boot-starter

Spring Boot Starter for QuickFIX/J
Apache License 2.0
125 stars 57 forks source link

@AutoConfiguration annotation compatible #105

Closed ChildrenGreens closed 1 year ago

ChildrenGreens commented 1 year ago

Regarding whether the @AutoConfiguration annotation in the QuickFixJClientAutoConfiguration class can be compatible.

Since I use a lower version of Spring Boot 2.5.8, there is no @AutoConfiguration annotation, so the "clientInitiator" bean cannot be loaded.

There is no need to use the @AutoConfiguration annotation for this project, @Configuration is enough

esanchezros commented 1 year ago

Hey @ChildrenGreens, fair point. I think the starter should be compatible with 2.x version of Spring Boot. I'll try fixing this issue today

esanchezros commented 1 year ago

btw, OSS support for Spring Boot 2.5.8 was ended in May last year, although commercial support is still going for a bit longer. You should at least consider upgrading to 2.5.14 which will contain fixes to a few bugs.

esanchezros commented 1 year ago

Hi @ChildrenGreens, I just released version 2.15.3, which gets rid of @AutoConfiguration annotation. Please let me know if this version works for you. Thanks

ChildrenGreens commented 1 year ago

@esanchezros Thank you for your suggestion on upgrading to Spring Boot 2.5.14. I will look at the source code and tags later and make an evaluation.

esanchezros commented 1 year ago

Closing for now, @ChildrenGreens please feel free to reopen if necessary.