Closed tensionhead closed 1 year ago
Patch coverage: 76.10%
and project coverage change: +0.01%
:tada:
Comparison is base (
86234a8
) 69.31% compared to head (765cf77
) 69.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wow, great to hear that you did not have to mess with the Selector logic at all to allow non-contiguous and unorderd channel_i and channel_j selections.
Changes Summary
channelcmb=[senders, receivers]
forspy.connectivityanalysis
selectdata
now allow non-contiguous and unorderdchannel_i
andchannel_j
selections, there was no reason apparent why this was not allowed before (I did not fiddle with any selection mechanics inside theSelector
)Now users can fine tune the channel-pairs for which to compute the connectivity measure as in FieldTrip:
will compute only 6 pairs: (01, 05, 08, 31, 35, 38) and the resulting
CrossSpectralData
is rectangular in the channel axes withchannel_i=senders
andchannel_j=receivers
.Note: the old way of doing a channel selection on the input:
would instead compute 20 pairs (+diagonal): the full dyadic (or tensor) product of those 5 channels.
Implementation differs according to the method
Granger causality
CrossSpectralData
object. The factorization algorithm is most stable when only computing pairs, however for many trials/few channels it would be much more effective to compute more pairs at once.CSD/PPC
Coherence
channel_i/senders
channel_j/receivers
combinations which now is possible.Limitations
('coh', 'csd', 'ppc', 'granger')
SpectralData
) as re-writing the whole implicitfreqanalysis
part when inputtingAnalogData
intoconnectivityanalysis
would require some bigger refactoring (design is actually bad for historic reasons)channelcmb
Reviewer Checklist