search

espruino / EspruinoTools

JavaScript library of tools for Espruino - used for the Web IDE, CLI, etc.
Apache License 2.0
150 stars 89 forks source link

Remove unicode.js #142

Closed gfwilliams closed 2 years ago

gfwilliams commented 2 years ago

... or at least make it switchable, default off.

Causing nothing but trouble since it's creation.

http://forum.espruino.com/conversations/367900/#comment16220079

I'd be interested to hear if anyone is actually using this? It seems the only use case is when printing non-latin characters to the console. For everything else it breaks perfectly ok code.

GermanWarez commented 2 years ago

Is it still in the code, couldn't find it - maybe close the issue?

gfwilliams commented 2 years ago

https://github.com/espruino/EspruinoTools/blob/master/plugins/unicode.js

gfwilliams commented 2 years ago

Looks like it's now disabled by default, so we could close this I guess