Pretokenization broken for at least BangleApps

espruino / EspruinoTools

JavaScript library of tools for Espruino - used for the Web IDE, CLI, etc.

Apache License 2.0

150 stars 89 forks source link

Closed halemmerich closed 5 months ago

halemmerich commented 5 months ago

It seems this change https://github.com/espruino/EspruinoTools/commit/cf60c6f44bacad2d7d84bb4ea5b232ce0d88c118# prevents the apploader to pretokenize any files. Espruino.Config.SAVE_ON_SEND is false by default in the Bangle apploader on updating/installing apps so this never does not hit.

gfwilliams commented 5 months ago

Ok, just fixed - turns out I could just set SAVE_ON_SEND to -1

Thanks for this - it'll end up making a huge difference to speed. Hopefully we won't start seeing new errors from it though!

halemmerich commented 5 months ago

Great, thanks. Reinstalling all apps on my bangle went smooth. So far no problems :)