search

esrille / escudo

The Escudo Web Browser
Apache License 2.0
68 stars 13 forks source link

[HTML] Remove the dependency on HTMLElementImp::eval() #12

Closed ShikiOkasaka closed 11 years ago

ShikiOkasaka commented 11 years ago

Switch out eval() for new handleMutation() method if possible.

ShikiOkasaka commented 11 years ago

1) d457ddb15520ca7b04dffc90d2713121c4c56107 2) b1f79085f440001a07e9b13e1b6819cde7dce25c 3) 8dd0bebdc216e18135e5f5c5f3ca352432cf2a61 4) 71a4e2a4cc8afff322c8b3f1bb04f3dcc014f944 5) 0974c72a9f0f8392624d4fb6c5cef73f84ff39f7 6) ee6c041ccc1d268f2f05f80321a8a927a50b70b8 7) 4669f220fba75d9c34a171f5d3b00cca8330fc6f 8) 87ea0a9667269e08b8b282c68964a6105c18aa95 9) 99595d237cbf29b6beacb381d775d35e1d87c067 10) aab524c7570b5b2c5c8aa76d5b78ea36aad818d0

ShikiOkasaka commented 11 years ago

At 4bf4ee1df62810e3c98dd70242a7c04c5cc37b33, the remaining eval() functions are needed by their own reasons. Note the timing that they are called is still wrong and needs to be examined by another issue.

ShikiOkasaka commented 11 years ago

The style element needs to reflect the dynamic change as well; cf. #45

ShikiOkasaka commented 11 years ago

Fixed at 739eaac16c4f69ee1681c8030298d67b665501d2

ShikiOkasaka commented 11 years ago

The align attribute of the div element could be processed like the other presentational hints without using eval().

cf. http://www.w3.org/TR/html5/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints

ShikiOkasaka commented 11 years ago

Fixed at cad98ad36cd43e06bb6df899a9e765b6e8b4ea15

ShikiOkasaka commented 11 years ago

The size attribute of the input element could be processed like the other presentational hints without using eval().

ShikiOkasaka commented 11 years ago

Fixed at 8d30cb18456163149b66108b40a60ffd0b9eaef2

ShikiOkasaka commented 11 years ago

Note remaining elements that still use eval() are link, object, and, td/th.

ShikiOkasaka commented 11 years ago

The border attribute of the table element could be processed by CSS; cf. http://www.w3.org/TR/html5/rendering.html#tables

ShikiOkasaka commented 11 years ago

Removed HTMLTableCellElementImp::eval() at ce43c24fcb9ca296b1fa040beb1eceef03222480

ShikiOkasaka commented 11 years ago

The two remaining elements, link and object, could not be implemented without using eval() at this point. Sync up with issue #17 to support event loops, etc.

ShikiOkasaka commented 11 years ago

Fixed the link element at 2536937923cf7d701d1af90eab321abb68ab47fa.

ShikiOkasaka commented 11 years ago

Fixed the object element at 806c1c2eb504a111faa97080ee9ee52fcc94c6d0.

ShikiOkasaka commented 11 years ago

Fixed at fa1192934842ef7af4e029c52e32d4e27794d7fb.