search

esrille / escudo

The Escudo Web Browser
Apache License 2.0
68 stars 13 forks source link

Use ICU library shipped by OSX #37

Closed Constellation closed 11 years ago

Constellation commented 11 years ago

OSX ships ICU library (libicucore.dylib) by default, but headers are not shipped. By including WebKit/Source/JavaScriptCore/icu & WebKit/Source/WebCore/icu headers, we can use OSX ICU library directly.

configure.ac: Add OSX ICU library check icu/LICENSE: New icu/unicode/bytestream.h: New icu/unicode/chariter.h: New icu/unicode/localpointer.h: New icu/unicode/parseerr.h: New icu/unicode/platform.h: New icu/unicode/ptypes.h: New icu/unicode/putil.h: New icu/unicode/rep.h: New icu/unicode/std_string.h: New icu/unicode/strenum.h: New icu/unicode/stringpiece.h: New icu/unicode/ubrk.h: New icu/unicode/uchar.h: New icu/unicode/ucnv.h: New icu/unicode/ucnv_cb.h: New icu/unicode/ucnv_err.h: New icu/unicode/ucol.h: New icu/unicode/ucoleitr.h: New icu/unicode/uconfig.h: New icu/unicode/ucsdet.h: New icu/unicode/uenum.h: New icu/unicode/uidna.h: New icu/unicode/uiter.h: New icu/unicode/uloc.h: New icu/unicode/umachine.h: New icu/unicode/unistr.h: New icu/unicode/unorm.h: New icu/unicode/unorm2.h: New icu/unicode/uobject.h: New icu/unicode/urename.h: New icu/unicode/uscript.h: New icu/unicode/usearch.h: New icu/unicode/uset.h: New icu/unicode/ushape.h: New icu/unicode/ustring.h: New icu/unicode/utext.h: New icu/unicode/utf.h: New icu/unicode/utf16.h: New icu/unicode/utf8.h: New icu/unicode/utf_old.h: New icu/unicode/utypes.h: New icu/unicode/uvernum.h: New icu/unicode/uversion.h: New

Constellation commented 11 years ago

This is the way WebKit uses OSX ICU library. http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/icu http://trac.webkit.org/browser/trunk/Source/WebCore/icu

Constellation commented 11 years ago

Or would you prefer installing icu4c by ports / homebrew?

ShikiOkasaka commented 11 years ago

I think we're fine with the WebKit ICU headers for now. Will you please move the 'icu' directory to 'src/third_party/icu'?

I think the following Chromium convention is a good practice for including the third party software in our repository: cf. http://www.chromium.org/developers/adding-3rd-party-libraries

Constellation commented 11 years ago

Looks nice to me too. I'll rebase it.

Constellation commented 11 years ago

I've rebased to move icu to src/third_party/icu.

ShikiOkasaka commented 11 years ago

:+1:

ShikiOkasaka commented 11 years ago

Merged at b59f1279fb764241554abf613c87d085d92dcfd4