Closed Wikinaut closed 11 years ago
http://beta.etherpad.org/p/mko3lhcx1J/timeslider is fine. Please provide steps to replicate.
no version number found in http://beta.etherpad.org/p/mko3lhcx1J/timeslider see issue #1078
checked several older versions on my system. All have (now) broken timeslider function (content is empty, or it is static).
The only change I remember:
Which node version is running on beta.etherpad.org ?
429651874f64f312d2a3dd09040aa2f8f44ed47b
Date: Mon, 22 Oct 2012 23:45:47 -0700 From: notifications@github.com To: etherpad-lite@noreply.github.com CC: john@mclear.co.uk Subject: Re: [etherpad-lite] Timeslider broken? (#1077)
checked several older versions on my system.
All have (now) broken timeslider function (content is empty, or it is static).
The only change I remember:
recent upgrade to node v0.8.12
—
Reply to this email directly or view it on GitHub.
I tried many things on my several independent reference installation. I have no idea, why the timeslider function stops working as designed. It's certainly a case for you experts!
I noticed: no "flickering" connection. (looks, as if there were no bytes sent from client to server). Perhaps a problem with socket.io ?
Shows an error
length is null or not an object
ace2_common.js Line: 36
Code: 0 Char: 216
URI:
``´
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.0.3705; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; InfoPath.1; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E)
Timestamp: Tue, 23 Oct 2012 14:20:02 UTC
Message: 'length' is null or not an object
Line: 36
Char: 216
Code: 0
URI: https://server/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define
Timeslider debug
[2012-10-25 20:26:40.363] [DEBUG] ueberDB - GETSUB - pad:6WbzPn9GHtAm:revs:99["meta","timestamp"] - 1346740294159 [2012-10-25 20:26:40.369] [ERROR] console - TypeError: Cannot read property 'length' of undefined at nextText (/srv/etherpad/src/static/js/Changeset.js:1943:24) at Object.exports.inverse (/srv/etherpad/src/static/js/Changeset.js:1995:22) at async.series.callback.forwardsChangesets (/srv/etherpad/src/node/handler/PadMessageHandler.js:1265:35) at async.series.results (/srv/etherpad/src/node_modules/async/lib/async.js:486:21) at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:185:13) at async.forEachSeries.iterate (/srv/etherpad/src/node_modules/async/lib/async.js:108:13) at async.forEachSeries.iterate (/srv/etherpad/src/node_modules/async/lib/async.js:119:25) at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:187:17) at async.series.results (/srv/etherpad/src/node_modules/async/lib/async.js:491:34) at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:190:13) [2012-10-25 20:26:40.369] [INFO] console - graceful shutdown...
you can move the slider, but nothing happens.
In addition:
I also noticed that - when starting the timeslider - the time pin "needle" (the small slider image) is positioned o a position clearly outside the time bar (between the right end of the time bar and the big "play" button with the triangle.
the function is also broken on
still broken in
Yes, I deleted /src/nod_modules before upgrading.
update
In addition part 2:
I also noticed that - when starting the timeslider - the time pin "needle" (the small slider image) is positioned o a position clearly outside the time bar (between the right end of the time bar and the big "play" button with the triangle.
Before starting "play", when I move the timeslider (which is on my systems always outside(!) the bar when starting the timeslider page) to a position on the bar, then it works !
Can anyone try to reproduce this bug?
I'm trying. I use node v0.8.14, I run 05cc7b3. But when starting the server it just works... (see http://localhost:9001/p/DdX8IYxrhV/timeslider -- does this work for you at least?)
Can you set up a new environment, please?
git clone git@github.com:Pita/etherpad-lite.git
3 cd etherpad-lite
git checkout develop
bin/run.sh
Same problem !
updated:
Timeslider "needle" is positioned offside the bar (between bar and play button).
Before starting "play", when I move the timeslider (which is on my systems always outside(!) the bar when starting the timeslider page) to a position on the bar, then it works !
Can anyone try to reproduce this bug?
Where can I "pastebin" a screenshot ?
screenshot of broken timeslider = http://imgur.com/xs9mx
[update 30.10.2012 : this CSS problem is fixed in d9298778650eb7be2181dc9aaf23e14faff61e99 ]
We have test cases in place for this bug and they aren't firing an error so I'm not sure what is going on. As far as the location of the slider image we don't have a test for that so I will write one.
@Wikinaut Timeslider "needle" is positioned offside the bar (between bar and play button).
Which browser?
I'm unable to replicate either bug. Can you replicate them on http://beta.etherpad.org ?
"not working" means: needle moves, but changes are not shown
IE9 timeslider is fine FF 15 position is fine.
@wikinaut are you testing on http://beta.etherpad.org or some other instance and does this instance have some buggy plugin installed or something?
I am using fresh installation on two fully different, distinct and separated virtual servers. One runs OpenSuse 11.3, the other runs SLES-11 (Suse-Linux-Enterprise Edition).
As you know, my installations ran for many months smoothly without problems. I am wondering why nobody else appears to have the Timeslider problems.
@ Johnyma22: FF15 is outdated, FF 16.0.2 is current version. Pls. can you upgrade and check ?
[this comment is deleted; the problem here was a spooky second "etherpad" task, kill - u etherpad solved that]
Whats the URL I can see this on? If you can't replicate on http://beta.etherpad.org I dunno what to suggest ;/
Bingo! "luckily" you can see it here on your own pad! http://beta.etherpad.org/p/test/timeslider
Timeslider also not working on your pad.
Tested in Firefox 16 and it's fine.
[removed]
Ah I can replicate the CSS bug better by creating long contents in a pad
setSliderPosition appears to be running before the pad content is available so this bug appears to be caused by a race condition where $("#ui-slider-bar").width() is modified once the vscroll bar is shown. Ideally $(window).resize(function() would fire when the vscroll bar is added by the browser but it isn't. See: http://api.jquery.com/resize/
"don't do" .... waiting for a fix. Then I will immediately test all my systems and report to you.
There ya go. Donations welcome!
hehe my donations are: mediawiki extension for Etherpad Lite, incl. support & extensive deep bug findings
Deep bug? ;) This was a pesky CSS/simple UI bug and could have been fixed by anyone w/ 15 mins if the bug report had been clear/well enough tested.
Sorry @Wikinaut, just had a long day, thanks for pointing out the bug :)
this fixes the CSS issue, but not the "timeslider broken" issue.
I really can't see how your timeslider is broken though.. Can you please give me exact steps to replicate the failing?
As I told you: look to http://beta.etherpad.org/p/test/timeslider , start "play" button: no changes are shown. Same on my version d9298778650eb7be2181dc9aaf23e14faff61e99
Yep that's broken :\
Please also add the version info plugin to beta http://beta.etherpad.org/ so that we can refer to the version
(But I can confirm, that the CSS issue is fixed)
It's actually fine in 4296518
I managed to get this to break once but now it's fine and I can't replicate. It is for sure fine cross browser on latest develop when creating a new pad. Could this be related to bad pad content or something?
It's actually fine in 4296518
Wishful thinking. It is not working for me. I checked out that version, cleared caches and /src/node_modules. Timelider is broken.
Please provide exact steps including a video / screen capture of your steps to replicate this bug on a fresh install. I'm unable to do it.
Steps to replicate:
Please fix this, and I will be quiet. Someone has horribly broken the working system.
see also https://github.com/Pita/etherpad-lite/issues/1068 .
Steps to replicate version 2
Giving up now. Waiting until someone else reports this again. see also https://github.com/Pita/etherpad-lite/issues/1068 .
visit one of existing pads
<-- This is a problem cause my pads aren't the same as your existing pads ergo making this test completely impossible to reproduce ;\ I think the problem is a bad changeset somewhere and that is pad specific.
Can you create this problem on a new pad? The point you appear to be missing is that you have to isolate a problem before you can fix it.
hhehe- the problem is apparent on your http://beta.etherpad.org/p/test/timeslider .
What I noticed is similar to the problems reported in https://github.com/Pita/etherpad-lite/issues/1068 : after a while, ro when you manually set the slider to a certain time, or move slowly, I can happen, that the content changes are shown.
I suppose it is a timing problem, which breaks the communication.
I just noticed, that the Timeslider function is broken. It does not work, shows an empty content frame, or the current content (static) but flickering without displaying any changes.