search

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
82 stars 61 forks source link

ECIP 1049 adopts the SHA3 Standard #365

Closed p3c-bot closed 4 years ago

p3c-bot commented 4 years ago
p3c-bot commented 4 years ago

@YazzyYaz the request for Last Call is to finalize the implementation spec. The only difference between Keccak-256 and SHA3 is the either 0x1 or 0x6 bit that goes into the padding. This PR finalizes it on the SHA3 variant of 0x6, we didn't know a year ago when it was proposed during the first 51% attack that this is what the community would favor. We also added in the implementation plan of 14,000,000 that is time sensitive, and based on the timings of when this was moved to Last Call.

Because both of these changes were just parameter changes, my thought was that they fall in the scope of a Last Call change.

YazzyYaz commented 4 years ago

@p3c-bot the parameter changes modify the whole proposal, kinda like if I modify a few parameters in Ethash, I can create a new algorithm altogether.

As it stands, your PR will make this ECIP the same as the existing Vanilla SHA-3 in Last Call as well.

Perhaps instead, you can defer it and add yourself as an author to Stevan's ECIP? This is to preserve the history of the ECIP altogether. If other editors don't feel the same way, that's fine and they can approve it.

developerkevin commented 4 years ago

Quickly: I think given Zac's thoughts on using Keccack might be better for the network as it's native to ethereum, whereas SHA3 is not, and there's little to no chance of them implementing SHA3 on ETH.

q9f commented 4 years ago

Don't want to derail this PR but I subscribe to what Kevin just said. ref https://github.com/ethereum/EIPs/issues/2951

If it's just the padding difference 0x1 or 0x6, why not use keccak256?

q9f commented 4 years ago

I also agree with Yazzzzz by the way. It would be cleaner to withdraw 1049 and continue working on 1095 in case we decide for vanilla SHA3-256.

q9f commented 4 years ago

Can we update this prior to the call tomorrow?

q9f commented 4 years ago

Ok, it looks like this is on hold depending on what we discuss today.

q9f commented 4 years ago

Closing this. Please rework the proposal based on Keccak256 and reopen the PR. Thanks!

Ref #362