ECIP 1103: Magneto EVM and Protocol Upgrades

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org

82 stars 61 forks source link

ECIP 1103: Magneto EVM and Protocol Upgrades #412

Closed q9f closed 3 years ago

q9f commented 3 years ago

ref #411

_Enable the outstanding Ethereum Foundation Berlin network protocol upgrades on the Ethereum Classic network in a hard-fork code-named Magneto to enable maximum compatibility across these networks._

stevanlohja commented 3 years ago

Is the proposal substantiated with a roadmap and strategy pertaining to ETC other than merging ETH updates?

gitr0n1n commented 3 years ago

The proposal needs to be substantiated with a roadmap and strategy pertaining to ETC other than merging ETH changes.

I haven't seen that as a requirement for submitting an ECIP. Please cite in the ECIP-1000 where it mentions this requirement. Thanks!

Also, I don't see this ECIP as out of left field. I believe protocol parity remains a roadmap goal of ETC, unless @stevanlohja has some new information to share with the network participants. The Berlin updates continue the goals of the established path to keep ETC and ETH interoperable. The specific EIPs should definitely be anaylzed and debated, but this proposal itself does not appear out of line.

q9f commented 3 years ago

I'm happy to collaborate on a roadmap if anyone wants to champion this. Not really relevant for this proposal though. Having the protocol updated to the latest version is the least we can do unless we want to developers to use xDAI or Binance Chain instead.

slavserver commented 3 years ago

won't you all calm down? ))

meowsbits commented 3 years ago

Parity. In order for this proposal to match the Berlin Network Upgrade Specification it (now) needs to remove EIP-2315.
Timelines. I assume that the block numbers in the spec are intended tentatively. Ethereum is aiming for an ETH mainnet activation at 12_244_000 (14 Apr 2021), and this spec proposes "May 2021" for ETC mainnet activation. For the sake of conservative risk management I propose targeting a minimum of 45-60 days behind the intended ETH activation.

meowsbits commented 3 years ago

We have some cross-client tests generated including subtests for the Magneto configuration. I have them as a WIP PR here: https://github.com/etclabscore/tests/pull/4. Still under development and review, so don't treat them as a concrete reference just yet, but should be good for starters. Development versions of CoreGeth pass all incumbent and generated tests (for Berlin, Magneto, and all preceding and test fork configurations).

Generated/filled tests are extrapolated from the standard https://github.com/ethereum/tests suite, with CoreGeth filling additional tests for Ethereum Classic fork configurations using Ethereum-canonical fork configurations as reference for Pre-State and Transaction parameters (in the case of the GeneralStateTests).

Test generation has been done on top of the latest version pegged by ethereum/go-ethereum v1.10.1 at https://github.com/ethereum/tests/tree/c600d7795aa2ea57a9c856fc79f72fc05b542124.

drospa commented 3 years ago

@q9f can you also add that Mantis (maintained by IOHK) will support this HF but at a later state than the proposed 13_189_133 on ETC PoW-mainnet (July 21st, 2021)?