ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
81 stars 61 forks source link

Rename: Alphabetize Editors List, Add Current Team Association to Current Editors #469

Closed gitr0n1n closed 2 years ago

gitr0n1n commented 2 years ago

Addresses PR:

gitr0n1n commented 2 years ago

Not sure what's going on with your account Antoine Toulme ( @atoulme ). I haven't been able to tag you in anything related to ECIP editor tasks.

@realcodywburns can you take a look at ECIP Editor permissions to see if it needs some updating when you have a moment? There might be some people that have ECIp Editor perms that have moved on. Will you perform an inspection clean these up in GitHub please?

realcodywburns commented 2 years ago

Screenshot_20220225-051616_Chrome

latest members

gitr0n1n commented 2 years ago
  • [x] I would like to include @soc1c's original commit: 397130b in the version history. Perhaps you can checkout his branch, revert his commit (maintaining a record of it), then make your proposal in a subsequent patch.
  • [x] The addition of alleged institutional associations (according to... you?) to the identities is a substantive and unrelated change. Please remove them.
  • [x] Please un-re-order the lists so I can read the diff clearly.

Addressed.

gitr0n1n commented 2 years ago

Screenshot_20220225-051616_Chrome

latest members

It doesn't appear Antoine Toulme ( @atoulme ) has permissions for ECIP Editor. Is he a valid ECIP editor? And do his permissions need to be updated? I believe Stev added him to this document. Is he that "1 pending member"?

bobsummerwill commented 2 years ago

This whole PR is all a bit of a mess and it might be best to start again fresh.

I just wanted to confirm that Antoine is an ECIP editor, whatever the Github permissions may say. Those permissions are secondary to the text of the ECIP.

Actions from CDC 20 included adding Antoine and Istora as ECIP editors. https://github.com/ethereumclassic/ECIPs/issues/453

gitr0n1n commented 2 years ago

This whole PR is all a bit of a mess and it might be best to start again fresh.

I just wanted to confirm that Antoine is an ECIP editor, whatever the Github permissions may say. Those permissions are secondary to the text of the ECIP.

Actions from CDC 20 included adding Antoine and Istora as ECIP editors. #453

Thanks for confirmation @bobsummerwill ! I'll just close this PR and throw up different ones. I agree its a bit of a mess now with @meowsbits requested changes.