search

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
81 stars 61 forks source link

Fix 1107 order appearance on web #477

Closed gitr0n1n closed 2 years ago

gitr0n1n commented 2 years ago

ECIP1107.md to ecip1108.md

Thought is that the uppercase filename is making this ECIP populate out of order in the lists on ecips.ethereumclassic.org. With this IM change it should fix that issue.

IstoraMandiri commented 2 years ago

Right; why change the number and not just lowercase the filename?

gitr0n1n commented 2 years ago

@IstoraMandiri @atoulme does it make sense that it is sorting to the top due to the ECIP being uppercase vs all others being lowercase? I'm trying to trouble shoot what i see on the ecips.ethereumclassic.org

image

We just changed this from ECIP-0001.md to ECIP-1107.md So I was trying ecip-1108.md since github wont recognize a rename from UPPERCASE to lowercase as a change.

Let me know if there is a different way that will trigger github to update the file name to be all lowercase.

IstoraMandiri commented 2 years ago

Yeah, it probably is due to it being uppercase.

The best way to see what works is to build it locally outside of github, but it might be annoying to get an environment set up for for non developers. I'll investigate a bit further see if it's worth adding a docker container to make local development much easier.

You can trigger rebuilds on github in the Actions tab https://github.com/ethereumclassic/ECIPs/actions, but I'm not sure whether it will generate previews for branches/PRs like this.

gitr0n1n commented 2 years ago

Fixed it!