search

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
82 stars 61 forks source link

Fix author links #479

Closed gitr0n1n closed 2 years ago

gitr0n1n commented 2 years ago

Combed the http://ecips.ethereumclassic.org/all for broken author links or mismatched links and updated.

IstoraMandiri commented 2 years ago

It is not obvious that this is referring to GitHub user names, so perhaps we can link them automatically in future, but that would require a pull request to modify the build.

In the meantime, this seems like a reasonable approach.

gitr0n1n commented 2 years ago

I'm not sure about removing the emails, perhaps ask these authors first?

I think a proper approach would be to include additional fields for Github ID and Emai, and show both in the UI somehow.

Yeah that would be a great solution. Many of these emails are likely dead since they are on disbanded team emails. I thought it was appropriate to update the emails to that authors most recent contact information.

As an example many of the etcdev.com etclabs.org ethereumclassic.com ethereumclassic.org emails are likely invalid, whereas their github names are active.

IstoraMandiri commented 2 years ago

Right, having checked it out, this is configured in https://github.com/ethereumclassic/ECIPs/blob/master/_includes/authorlist.html, which does support both right now depending on whether the name has an (@ or an <, but will default to email if there's both.

While it is possible, I would rather not have to add additional UI elements as it clutters things up, so I can see why changing everything to github ids makes more sense.

I would like to hear some other maintainers thoughts about this?

gitr0n1n commented 2 years ago

Sounds good. I'll close this clean-up PR.