search

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
82 stars 61 forks source link

ECBP-1110: Deactivate MESS #520

Closed meowsbits closed 9 months ago

meowsbits commented 10 months ago

Turn off the artificial finality mechanism ECBP-1100's MESS (Modified Exponential Scoring) in Core-Geth for Ethereum Classic.

Rendered document: https://github.com/meowsbits/ECIPs/blob/ecbp1110/_specs/ecip-1110.md

FYI I'll also be updating https://meowsbits.github.io/51-percent-docs/ this week, which provides some useful context.

gitr0n1n commented 9 months ago

To clarify @meowsbits, MESS still exists in the client as a tool should it ever be needed again by client users, but this removes the default activation setting and adjusted the setting to "off" by default?

Also for status, do we want to update 1100 with "Replaced by 1099" or something to that effect? Or keep as active, since it is still present in the client, but just not turned on by default?

bobsummerwill commented 9 months ago

Discussion ongoing here: https://github.com/orgs/ethereumclassic/discussions/522

gitr0n1n commented 9 months ago

Now that we have a a block set for Mordor. Is this ECIP in a final state for review? @ethereumclassic/ecip-editors there does not appear to be any contention with this ECIP proposal and discussion has been open at: https://github.com/orgs/ethereumclassic/discussions/522

Note it appears everyone agree MESS should not exist anymore. But the discussion is now whether to deactivate/remove fully. Noting deactivate and remove could be two stage. I'm approving the PR because the deactivate of MESS is no contentious. Removal of MESS entirely is where there is some conversation to still be had on the topic. Should removal be the deemed route, this PR certainly could be updated to reflect that.

I'll let you execute the merge @meowsbits in case you notice anything that needs to be cleaned up in the document.

gitr0n1n commented 9 months ago

Also for status, do we want to update 1100 with "Replaced by 1099" or something to that effect? Or keep as active, since it is still present in the client, but just not turned on by default?

@meowsbits can you comment on this? How should we adjust the status, if at all?

meowsbits commented 9 months ago

I like your Replaced idea on 1100, the original MESS (activation) spec, concurrent with this. Although I think leaving it would be logical too, I guess it will be more understandable if it's association with this 1110 spec is documented. Will do.

meowsbits commented 9 months ago

CI failed because Ruby's bundler install failed. Unrelated to changes here, so I'll go ahead with merge and fix the bundler issue later.

https://github.com/ethereumclassic/ECIPs/actions/runs/7463281525/job/20307577984?pr=520

Run gem install bundler
ERROR:  Error installing bundler:
    The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
    bundler requires Ruby version >= 3.0.0. The current ruby version is 2.6.10.210.
Error: Process completed with exit code 1.