ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
81 stars 61 forks source link

Fix/ecip validation bundler version #523

Closed meowsbits closed 6 months ago

meowsbits commented 6 months ago

https://github.com/ethereumclassic/ECIPs/actions/runs/7463320371 ecip_validator actions were failing because of a bundler version error.

Then, ecip-1100.md was failing validation because Replaced did not exist in the list of valid statuses at the ecip_validator, so I patched that and bumped the version for that here too.

https://github.com/meowsbits/ecip_validator https://rubygems.org/gems/ecip_validator

meowsbits commented 6 months ago

ecip_validator still complains about a few Warnings, but they're not critical.

ecip_validator _specs/*.md
Ignoring commonmarker-0.23.5 because its extensions are not built. Try: gem pristine commonmarker --version 0.23.5
Ignoring eventmachine-1.2.7 because its extensions are not built. Try: gem pristine eventmachine --version 1.2.7
Ignoring http_parser.rb-0.6.0 because its extensions are not built. Try: gem pristine http_parser.rb --version 0.6.0
Ignoring sassc-2.2.1 because its extensions are not built. Try: gem pristine sassc --version 2.2.1

frontmatterparser rescued from a nil death
Warning: _specs/ecip-1077.md     undefined method `keys' for nil:NilClass
Warning: _specs/ecip-1091.md     unknown attribute 'supersedes' for EcipValidator::Validator.
frontmatterparser rescued from a nil death
Warning: _specs/ecip-1107.md     undefined method `keys' for nil:NilClass

total:84, valid:81, invalid:0, errors:3
        statuses: [["Active", 3], ["Final", 13], ["Draft", 29], ["Withdrawn", 21], ["Superseded", 4], ["Rejected", 9], ["Replaced", 1], ["Last Call", 1]]
        types: [["Meta", 23], ["Standards Track", 55], ["Informational", 3]]
        categories: [[nil, 25], ["Core", 40], ["ECBP", 7], ["Interface", 7], ["Networking", 2]]
        layers: [[nil, 81]]

nun 24-01-09T11:01:53 ~/dev/ethereumclassic/ECIPs fix/ecip-validation-bundler-version *
echo $?
0