search

ethereumclassic / ECIPs

https://ecips.ethereumclassic.org
81 stars 61 forks source link

Update ecip-1066.md #526

Closed chris-mercer closed 2 months ago

chris-mercer commented 5 months ago

Add Spiral

meowsbits commented 5 months ago

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

gitr0n1n commented 5 months ago

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

Done! 7c210cf6e166e30992f8a6f77ec5f36289784e47

meowsbits commented 4 months ago

Cool thanks :+1:

realcodywburns commented 4 months ago

How was eip-6049 implemented? It is not included in the 'expected action' portion and the spec is dubious + poorly defined. My understanding is this is a warning in documentation(?) to not use selfdestruct. As written, 6049 opens the door to reuse the opcode for something that a contract may not have intended when deployed. In the comments in geth it looks like we will eventually treat it as a noop after the activation block. I would recommend having it as a permanent 'noop' and not be allowed to be repurposed. ack this flag allows compatibility with eth. Its implementation or lack there of is included in this ecip update

meowsbits commented 4 months ago

In core-geth IsEIP6049 is inoperative; it's just a paper placeholder, and afaiu that's the spec. Duly noted on the suggestion to permanent noop it.

realcodywburns commented 4 months ago

Sounds good to me. can we squash merge this now?