search

ethz-asl / robot_control

1 stars 2 forks source link

Fix/build server WIP #17

Closed grizzi closed 4 years ago

grizzi commented 4 years ago

This PR is to check that modifications will make the build server work, hopefully. Once it works, I will merge in the controller branch or directly to master if that is merged already

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test FAILed.

ethzasl-jenkins commented 4 years ago

Test PASSed.

grizzi commented 4 years ago

@kekeblom After a painful afternoon, the build server finally builds. So there are some hacks here.

  1. To avoid the hassle to install pinocchio everytime, I have installed it using the ppa. The problem is that we would need sudo privileges to do it. This is why Florian had to add the repo manually on a machine, which is the only one where the build runs now.

  2. The environment variables pointing at the pinocchio package cannot be set from the prepare script since the is executed in a subshell and the environmental variables would be visible only there. The scripts should be sourced which would require to change the continuous_integration repo from which the script is taken. The solution: adding a separate script which source these variables before the build separately and before the preparation script is run. This file is source_env.sh

  3. The robot_control_bullet package could not run successful test because the pybullet, scipy and numpy were not found. I thought they where installed, being dependencies in the setup.py. Apparently this is not true. I am installing them in the setup script.

  4. The python test which depends on the python bindings of pinocchio does not find pinocchio. It is added to the python_path, therefore I do not know why it is complaining. It is not anything important so I have just disabled this test for the moment.

A cleaner solution could be to have pinocchio as a submodule, but this would require it to be built every time? At least now we have a building workspace. We can decide to either keep this for now or address the issues I have listed. @kekeblom What do you think?

BTW: Are you being spammed by jenkins? If this is the case, I can try to remove the email notifiactions.

ethzasl-jenkins commented 4 years ago

Test PASSed.

grizzi commented 4 years ago

@kekeblom wdyt? We could try to merge this into the pending controller request

kekeblom commented 4 years ago

Yes it looks good to me. The pinocchio path for python is a pain and yeah probably not worth spending too much time on that before we have substantial use of the python bindings.

ethzasl-jenkins commented 4 years ago

Test PASSed.